Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Aidan Van Dyk <aidan@highrise.ca>, git@vger.kernel.org
Subject: Re: Trying to get GIT running on SCO OpenServer
Date: Wed, 23 Jan 2008 16:25:01 -0800	[thread overview]
Message-ID: <7vsl0oax42.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0801232346010.5731@racer.site> (Johannes Schindelin's message of "Wed, 23 Jan 2008 23:48:16 +0000 (GMT)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> FWIW we had the same problem in MinGW, and Hannes Sixt solved it:
>
> http://repo.or.cz/w/git/mingw/j6t.git?a=commitdiff;h=b8e84a68f01a2386b2071e1bdc8e24de809a3f6d
>
> That might give you an idea how to solve the issue.  Maybe you even make a 
> git patch out of it?  With a Makefile variable BROKEN_SNPRINTF=YesPlease, 
> maybe?

Hmmm.  Looking at that change makes me wonder if that solution
is Kosher.  The value of the va_list you pass to vsnprintf() is
unspecified after the call.

It may be Ok as mingw-only "compatibility wrapper", but I think
you have to be a bit careful.  It is not a general solution for
any BROKEN_SNPRINTF.

  parent reply	other threads:[~2008-01-24  0:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23 21:26 Trying to get GIT running on SCO OpenServer Aidan Van Dyk
2008-01-23 23:48 ` Johannes Schindelin
2008-01-24  0:17   ` Jakub Narebski
2008-01-24  0:25   ` Junio C Hamano [this message]
2008-01-24  2:33     ` H. Peter Anvin
2008-01-24  2:48       ` Junio C Hamano
2008-01-24  2:50       ` Linus Torvalds
2008-01-24  3:01         ` Luke Lu
2008-01-24  3:19           ` Linus Torvalds
2008-01-24 16:23 ` Aidan Van Dyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsl0oax42.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=aidan@highrise.ca \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox