From: Junio C Hamano <gitster@pobox.com>
To: David Miller <davem@davemloft.net>
Cc: git@vger.kernel.org
Subject: Re: end of file newline regression
Date: Sun, 16 Dec 2007 17:24:27 -0800 [thread overview]
Message-ID: <7vsl22glkk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071216.155413.165709543.davem@davemloft.net> (David Miller's message of "Sun, 16 Dec 2007 15:54:13 -0800 (PST)")
David Miller <davem@davemloft.net> writes:
> I've stumbled into a problem with current mainline.
>
> I have this changeset that I can't get GIT to properly
> generate diffs for. It always give me:
>
> diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> index 4440532..096974b 100644
> --- a/net/ipv6/esp6.c
> +++ b/net/ipv6/esp6.c
> @@ -177,5 +177,4 @@ static int esp6_input(struct xfrm_state *x, struct sk_buff *skb)
> BUG();
>
> if (unlikely(memcmp(esp->auth.work_icv, sum, alen))) {
> - x->stats.integrity_failed++;
> - ret = -EINVAL;
> \ No newline at end of file
> + ret = -EBADMSG;
> \ No newline at end of file
>
> No matter what I do, 1.5.3.7 doesn't do this.
Sorry, there was a recent brown-paper-bag. Should have been fixed with
the patches flew on the list for the past 24 hours or so. Could you try
it with the tip of 'master'?
prev parent reply other threads:[~2007-12-17 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 23:54 end of file newline regression David Miller
2007-12-17 1:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsl22glkk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davem@davemloft.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).