git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: git@vger.kernel.org, adobriyan@gmail.com
Subject: Re: [PATCH] Tweak git-quiltimport to allow more flexible series format
Date: Thu, 22 Nov 2007 15:43:53 -0800	[thread overview]
Message-ID: <7vsl2x26di.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071122134849.GB6240@localhost.sw.ru> (Alexey Dobriyan's message of "Thu, 22 Nov 2007 16:48:49 +0300")

Alexey Dobriyan <adobriyan@sw.ru> writes:

> Make quiltimport also understand comments following patch name.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
>  git-quiltimport.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/git-quiltimport.sh
> +++ b/git-quiltimport.sh
> @@ -63,7 +63,7 @@ tmp_info="$tmp_dir/info"
>  commit=$(git rev-parse HEAD)
>  
>  mkdir $tmp_dir || exit 2
> -for patch_name in $(grep -v '^#' < "$QUILT_PATCHES/series" ); do
> +for patch_name in $(sed -e 's/#.*//' < "$QUILT_PATCHES/series" ); do
>  	if ! [ -f "$QUILT_PATCHES/$patch_name" ] ; then
>  		echo "$patch_name doesn't exist. Skipping."
>  		continue

Is this consistent with the way quilt groks the series file?

IOW, does quilt forbid patchfile whose name contains a hash, and
anything after a hash on the line is taken as comment?

Can a line in a quilt series file name more than one patchfile?
If so, are they whitespace separated?

  reply	other threads:[~2007-11-22 23:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22 13:48 [PATCH] Tweak git-quiltimport to allow more flexible series format Alexey Dobriyan
2007-11-22 23:43 ` Junio C Hamano [this message]
2007-11-27 16:52   ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsl2x26di.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=adobriyan@gmail.com \
    --cc=adobriyan@sw.ru \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).