From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Johannes Sixt <johannes.sixt@telecom.at>, git@vger.kernel.org
Subject: Re: [PATCH] rehabilitate some t5302 tests on 32-bit off_t machines
Date: Thu, 15 Nov 2007 11:03:14 -0800 [thread overview]
Message-ID: <7vsl3749hp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.0.9999.0711151349480.21255@xanadu.home> (Nicolas Pitre's message of "Thu, 15 Nov 2007 13:51:47 -0500 (EST)")
Nicolas Pitre <nico@cam.org> writes:
> On Thu, 15 Nov 2007, Johannes Sixt wrote:
>
>> Since you changed this test, I assume that the remaining
>> tests that you put back failed only because this one did
>> something wrong. If so, please mention that in the commit
>> message.
>
> It did nothing wrong. It was simply relying on the product of
> a previous test that might still be disabled.
Thanks for a fix-up and clarification. Hannes, otherwise this
passed in your environment?
next prev parent reply other threads:[~2007-11-15 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 17:24 [PATCH] rehabilitate some t5302 tests on 32-bit off_t machines Nicolas Pitre
2007-11-15 18:38 ` Johannes Sixt
2007-11-15 18:51 ` Nicolas Pitre
2007-11-15 19:03 ` Junio C Hamano [this message]
2007-11-15 19:39 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsl3749hp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).