From: Junio C Hamano <gitster@pobox.com>
To: Wincent Colaiuta <win@wincent.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Add line-wrapping guidelines to the coding style documentation
Date: Wed, 14 Nov 2007 02:37:34 -0800 [thread overview]
Message-ID: <7vsl39i041.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <56A87A65-3C2E-4E10-84D4-4470879EE466@wincent.com> (Wincent Colaiuta's message of "Wed, 14 Nov 2007 11:19:05 +0100")
Wincent Colaiuta <win@wincent.com> writes:
> A statistician could probably make some interesting comments about the
> results, but the basic trend is that, while there are plenty of
> examples of isolated long lines in the source tree (the longest is a
> 287-character line in one of the perl scripts), the frequency starts
> to drop off pretty rapidly once you pass 70 columns and start climbing
> towards 80.
Gaah. 287???
> + - In the case of documentation, mixing excessively long and short
> + lines may make the AsciiDoc source harder to read, so try to
> + keep line lengths consistent.
> +
> + - When submitting patches use common sense to decide whether to
> + rewrap, avoiding gratuitous changes.
Hmph. The last item applies only to the documentation because
it uses the word "rewrap", but otherwise applies equally well to
the sources (re-indenting). So probably "whether to rewrap or
reindent" would be a good change there.
next prev parent reply other threads:[~2007-11-14 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 10:19 [PATCH] Add line-wrapping guidelines to the coding style documentation Wincent Colaiuta
2007-11-14 10:37 ` Junio C Hamano [this message]
2007-11-14 17:19 ` Johannes Schindelin
2007-11-14 19:00 ` [PATCH v3] " Wincent Colaiuta
2007-11-14 19:08 ` Andreas Ericsson
2007-11-14 20:04 ` Junio C Hamano
2007-11-14 20:23 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsl39i041.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).