git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jing Xue <jingxue@digizenstudio.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] replace reference to git-rm with git-reset in git-commit doc
Date: Sun, 11 Nov 2007 18:27:57 -0800	[thread overview]
Message-ID: <7vsl3c8afm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071112003845.GA7595@fawkes> (Jing Xue's message of "Sun, 11 Nov 2007 19:38:45 -0500")

Jing Xue <jingxue@digizenstudio.com> writes:

> On Sun, Nov 11, 2007 at 03:05:18PM +0100, Jan Hudec wrote:
>> 
>> The message in git-commit suggesting to use 'git rm --cached' to unstage is
>> just plain wrong. It really should mention 'git reset'.
>
> Hopefully this makes it clearer. I have also updated the faq in wiki to
> clarify.
>
> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
> index e54fb12..7c63dd8 100644
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -154,12 +154,12 @@ EXAMPLES
>  --------
>  When recording your own work, the contents of modified files in
>  your working tree are temporarily stored to a staging area
> +called the "index" with gitlink:git-add[1].  File changes
> +previously staged can be removed with `git-reset
> +HEAD -- <file>`.

I think "changes ... can be removed" risks to give a confused
mental model that somehow git tracks changes.  "A file can be
reverted back to that of the last commit with ..."  would be
less risky.

  reply	other threads:[~2007-11-12  2:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02  2:17 git rm --cached Jing Xue
2007-11-02 16:13 ` Remi Vanicat
2007-11-02 21:41   ` Jing Xue
2007-11-03  9:39     ` Remi Vanicat
2007-11-04 17:04     ` Matthieu Moy
2007-11-11 14:05 ` Jan Hudec
2007-11-12  0:38   ` [PATCH] replace reference to git-rm with git-reset in git-commit doc Jing Xue
2007-11-12  2:27     ` Junio C Hamano [this message]
2007-11-12  4:43       ` [PATCH] RESUBMIT: " Jing Xue
2007-11-14  8:56         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsl3c8afm.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jingxue@digizenstudio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).