From: Junio C Hamano <gitster@pobox.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tests: git push mirror mode tests V2
Date: Fri, 09 Nov 2007 12:05:43 -0800 [thread overview]
Message-ID: <7vsl3frxpk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1194603673.0@pinky> (Andy Whitcroft's message of "Fri, 9 Nov 2007 10:21:13 -0000")
Andy Whitcroft <apw@shadowen.org> writes:
> +test_expect_success 'push mirror does not create new branches' '
> +
> + mk_repo_pair &&
> + (
> + cd master &&
> + echo one >foo && git add foo && git commit -m one &&
> + git push --mirror up
> + ) &&
> + master_master=$(cd master && git show-ref -s --verify refs/heads/master) &&
> + mirror_master=$(cd mirror && git show-ref -s --verify refs/heads/master) &&
> + test "$master_master" = "$mirror_master"
> +
> +'
I am quite puzzled by this and many other "does not" in the test
description. The --mirror option is advertised as
- newly created will be pushed;
- locally updated will be force pushed;
- locally deleted will be removed.
which makes sense as we do want these things to happen for
"mirrors". Indeed the above updates master branch at the master
repository and makes sure that change is propagated to the
mirror repository. The description should read "push mirror
creates new branches" shouldn't it?
next prev parent reply other threads:[~2007-11-09 20:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 12:11 git push mirror mode Andy Whitcroft
2007-11-08 12:12 ` [PATCH 1/2] mirror pushing Andy Whitcroft
2007-11-08 12:12 ` [PATCH 2/2] git-push: plumb in --mirror mode Andy Whitcroft
2007-11-08 12:19 ` git push mirror mode Johannes Schindelin
2007-11-08 12:44 ` Andy Whitcroft
2007-11-08 13:14 ` Andreas Ericsson
2007-11-08 13:44 ` Andy Whitcroft
2007-11-08 13:48 ` Andreas Ericsson
2007-11-08 12:49 ` Andy Whitcroft
2007-11-08 21:53 ` Junio C Hamano
2007-11-08 14:24 ` [PATCH 1/2] mirror pushing Andy Whitcroft
2007-11-08 15:03 ` Johannes Schindelin
2007-11-08 14:25 ` [PATCH 2/2] git-push: plumb in --mirror mode Andy Whitcroft
2007-11-08 16:58 ` git push mirror mode V3 Andy Whitcroft
2007-11-08 17:00 ` [PATCH 1/4] mirror pushing Andy Whitcroft
2007-11-08 17:01 ` [PATCH 2/4] mirror pushing -- clean up match_refs flags Andy Whitcroft
2007-11-08 17:01 ` [PATCH 3/4] git-push: plumb in --mirror mode Andy Whitcroft
2007-11-08 17:01 ` [PATCH 4/4] tests: git push mirror mode tests Andy Whitcroft
2007-11-09 10:21 ` [PATCH] tests: git push mirror mode tests V2 Andy Whitcroft
2007-11-09 14:45 ` [PATCH] tests: git push mirror mode tests V2 -- add tag tests Andy Whitcroft
2007-11-09 15:01 ` [PATCH] git-push: add documentation for the newly add --mirror mode Andy Whitcroft
2007-11-09 20:05 ` Junio C Hamano [this message]
2007-11-12 15:25 ` [PATCH] tests: git push mirror mode tests V2 Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsl3frxpk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apw@shadowen.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).