From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: gitk from subdirectory
Date: Thu, 30 Aug 2007 22:29:44 -0700 [thread overview]
Message-ID: <7vsl6046gn.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0708302200160.25853@woody.linux-foundation.org> (Linus Torvalds's message of "Thu, 30 Aug 2007 22:08:26 -0700 (PDT)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Thu, 30 Aug 2007, Junio C Hamano wrote:
>>
>> I am wondering if this was intended behaviour change. I think
>> it makes sense to want an easy way to say "what changed stuff in
>> the directory I am in?" because presumably you are there because
>> you are interested in stuff in there. But if you hard code "--"
>> it is not easy to disable that and get the global log.
>
> Hmm. My reaction to this would be that it was a mistake to have a
> difference between
>
> git log --
>
> and
>
> git log
>
> and that we should instead fix this at the argument parsing level.
>
> And then anybody who depended on the old "--" behaviour can just add a "."
> at the end.
>
> That way there are no special cases.
>
> I realize that the "--" behaviour of git log was intentional, but seeing
> what it results in I think the intention was good, but stupid.
I haven't finished analysis yet, but I was reaching the same
conclusion.
v1.2.0 used to limit "git rev-list" to the current working
directory, v1.3.0 and newer does not. But they do when "--" is
given. This makes it impossible to do:
cd Documentation
echo >master
git rev-list master
... get "ambiguous -- which do you mean? rev, or
... limited to path?" error message
git rev-list master --
... I do mean unlimited and dig from 'master'
next prev parent reply other threads:[~2007-08-31 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 4:29 gitk from subdirectory Junio C Hamano
2007-08-31 4:33 ` Junio C Hamano
2007-08-31 5:08 ` Linus Torvalds
2007-08-31 5:29 ` Junio C Hamano [this message]
2007-08-31 5:32 ` Junio C Hamano
2007-08-31 5:45 ` Junio C Hamano
2007-08-31 5:51 ` Junio C Hamano
2007-08-31 7:38 ` Linus Torvalds
2007-08-31 7:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsl6046gn.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).