git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Kastrup <dak@gnu.org>
Cc: Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
	Jan Hudec <bulb@ucw.cz>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org
Subject: Re: Stupid quoting...
Date: Sun, 24 Jun 2007 05:19:12 -0700	[thread overview]
Message-ID: <7vsl8htuin.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <85myypef7p.fsf@lola.goethe.zz> (David Kastrup's message of "Sun, 24 Jun 2007 13:58:50 +0200")

David Kastrup <dak@gnu.org> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> If I were to create a patch between two versions of such a file, the
>> diff header would show the pathname encoded in one, and the changed
>> contents would ben shown in another.  As long as you treat "git
>> diff" output as binary blob, that would work just fine, but when you
>> have to transmit such a diff in e-mail as an in-line patch, you
>> would have troubles.
>
> ASCII-armoring of what amounts to binary files is the task of the mail
> software.  Also working with encodings.  Escaping characters in the
> diff headers but not in the file contents is not going to achieve
> anything useful, anyway.

You misunderstood me.  The issue is not about transmitting
without corruption.  Armoring would make it impossible to
COMMENTING on the patch INLINE.

And that is where the pathname quoting git diff does originally
comes from.

  reply	other threads:[~2007-06-24 12:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 11:30 Stupid quoting David Kastrup
2007-06-13 12:06 ` Alex Riesen
2007-06-13 12:21 ` Johannes Schindelin
     [not found]   ` <86ejkgvxmb.fsf@lola.quinscape.zz>
2007-06-14  0:51     ` Johannes Schindelin
2007-06-14  6:12       ` David Kastrup
2007-06-14  7:06         ` Alex Riesen
     [not found]           ` <86hcpb6lr6.fsf@lola.quinscape.zz>
2007-06-14  8:51             ` Alex Riesen
2007-06-14  1:06   ` Steven Grimm
2007-06-14  1:12     ` Johannes Schindelin
2007-06-14  1:19       ` Steven Grimm
2007-06-14  1:34         ` Johannes Schindelin
2007-06-14  8:49   ` Junio C Hamano
2007-06-16 21:03 ` Jakub Narebski
2007-06-18  8:00   ` David Kastrup
2007-06-18 16:19     ` Jeff King
2007-06-19  1:00     ` Johannes Schindelin
2007-06-19  7:44       ` David Kastrup
2007-06-19  9:50         ` Johannes Schindelin
2007-06-19 20:53           ` Olivier Galibert
     [not found]           ` <86645kutow.fsf@lola.quinscape.zz>
2007-06-20  2:19             ` Johannes Schindelin
2007-06-20  6:19               ` Junio C Hamano
2007-06-20  7:49                 ` David Kastrup
2007-06-20  8:40                   ` Jakub Narebski
2007-06-20  8:59                     ` David Kastrup
2007-06-24  6:50                 ` Jan Hudec
2007-06-24 11:14                   ` Robin Rosenberg
2007-06-24 11:47                     ` Junio C Hamano
2007-06-24 11:58                       ` David Kastrup
2007-06-24 12:19                         ` Junio C Hamano [this message]
2007-06-24 12:41                           ` Jeff King
2007-06-24 16:25                     ` Jan Hudec
2007-06-24 19:39                       ` Robin Rosenberg
2007-06-24 19:47                         ` David Kastrup
2007-06-24 20:17                           ` Robin Rosenberg
2007-06-24 20:25                             ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsl8htuin.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bulb@ucw.cz \
    --cc=dak@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg.lists@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).