From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org,
"Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
Subject: Re: [PATCH 01/02] ident.c: Use const qualifier when possible
Date: Sun, 15 Apr 2007 13:14:57 -0700 [thread overview]
Message-ID: <7vslb12y4e.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200704152106.51082.andyparkins@gmail.com> (Andy Parkins's message of "Sun, 15 Apr 2007 21:06:49 +0100")
Andy Parkins <andyparkins@gmail.com> writes:
> On Sunday 2007, April 15, Luiz Fernando N. Capitulino wrote:
>
>> -static const char *env_hint =
>> +static const char const *env_hint =
>
> You can see then that
>
> const char const *env_hint
>
> is redundant, it's simply saying twice that (*env_hint) is const.
I think he wanted to say
static const char *const env_hint = ...
next prev parent reply other threads:[~2007-04-15 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 18:51 [PATCH 01/02] ident.c: Use const qualifier when possible Luiz Fernando N. Capitulino
2007-04-15 20:06 ` Andy Parkins
2007-04-15 20:14 ` Junio C Hamano [this message]
2007-04-15 21:40 ` Luiz Fernando N. Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vslb12y4e.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=lcapitulino@mandriva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).