From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <junkio@cox.net>
Subject: Re: Funny reflog has missing space
Date: Tue, 27 Feb 2007 12:32:39 -0800
Message-ID: <7vslcrcpeg.fsf@assigned-by-dhcp.cox.net>
References: <200702271529.13258.andyparkins@gmail.com>
	<7v4pp7flew.fsf@assigned-by-dhcp.cox.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
To: Andy Parkins <andyparkins@gmail.com>
X-From: git-owner@vger.kernel.org Tue Feb 27 21:33:38 2007
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1HM90x-0004co-QJ
	for gcvg-git@gmane.org; Tue, 27 Feb 2007 21:33:36 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752543AbXB0Ucm (ORCPT <rfc822;gcvg-git@m.gmane.org>);
	Tue, 27 Feb 2007 15:32:42 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752539AbXB0Ucm
	(ORCPT <rfc822;git-outgoing>); Tue, 27 Feb 2007 15:32:42 -0500
Received: from fed1rmmtao105.cox.net ([68.230.241.41]:37650 "EHLO
	fed1rmmtao105.cox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752533AbXB0Uck (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 27 Feb 2007 15:32:40 -0500
Received: from fed1rmimpo02.cox.net ([70.169.32.72])
          by fed1rmmtao105.cox.net
          (InterMail vM.7.05.02.00 201-2174-114-20060621) with ESMTP
          id <20070227203239.STQV233.fed1rmmtao105.cox.net@fed1rmimpo02.cox.net>;
          Tue, 27 Feb 2007 15:32:39 -0500
Received: from assigned-by-dhcp.cox.net ([68.5.247.80])
	by fed1rmimpo02.cox.net with bizsmtp
	id UkYg1W0081kojtg0000000; Tue, 27 Feb 2007 15:32:40 -0500
In-Reply-To: <7v4pp7flew.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's
	message of "Tue, 27 Feb 2007 11:30:31 -0800")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
Sender: git-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/40789>

Junio C Hamano <junkio@cox.net> writes:

> Andy Parkins <andyparkins@gmail.com> writes:
>
>> Hello,
>>
>> I've just peeked in my reflog (tail .git/logs/HEAD), and found something 
>> strange:
>>
>> 72160ca5c05fab4fbd3c24c9b13cbd0651b60532 
>> ca7b20e2677960cfc52c525b8f8bdf12ce79176b Andy Parkins <long@emailaddress.com> 
>> 1172589175 +0000commit: Log message goes here
>>
>> Notice that there is no space between the "+0000" and the "commit".
>> ...
>> Is this normal?  "git-reflog show" works fine in both cases.
>
> It is not.  It would be good to find out who puts corrupted
> entry.

Hmmm.  I am puzzled.  The only two low-level locations I know of
that writes into reflog are:

 * builtin-reflog.c::expire_reflog_ent() copies existing log
   entry, which are parsed out, after reformatting it.  It has
   an explicit "\t" in the format string, so it is not it.

 * refs.c::log_ref_write() gets an optional log message and
   writes it after the GMT offset, with an explicit "\t", so
   this is not it, either.