From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook
Date: Wed, 20 Dec 2006 11:37:12 -0800 [thread overview]
Message-ID: <7vslfae4uv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200612200901.30584.andyparkins@gmail.com> (Andy Parkins's message of "Wed, 20 Dec 2006 09:01:30 +0000")
Andy Parkins <andyparkins@gmail.com> writes:
> Problems:
> - git-prune in the submodule could destroy supermodule-referenced
> commits
> - no checkout support
> - no merge support (other than what git provides for the .gitmodule
> file)
> - no check for dirty submodule before commit
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
I do not think these are insurmountable.
As you fix them and enhance the support, I suspect you would
want a separate command to manage .gitmodule file and submodules
referenced by it. I think it would be better to keep the patch
to the template to the minimum (for example, run "git submodule
update" if there is .gitmodules file at the toplevel), and
implement the body of the processing in "git-submodule.sh", or
something like that.
next prev parent reply other threads:[~2006-12-20 19:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-20 9:01 [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook Andy Parkins
2006-12-20 10:08 ` Andy Parkins
2006-12-20 11:49 ` Brian Gernhardt
2006-12-20 12:01 ` Jakub Narebski
2006-12-20 12:35 ` Andreas Ericsson
2006-12-20 14:47 ` [BUG] git --git-dir dies with bus error Brian Gernhardt
2006-12-20 11:59 ` [RFC/PATCH] Implement poor-man's submodule support in pre-commit hook Jakub Narebski
2006-12-20 12:11 ` Andy Parkins
2006-12-20 19:37 ` Junio C Hamano [this message]
2006-12-21 8:39 ` Andy Parkins
2006-12-21 8:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vslfae4uv.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).