From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jonas Fonseca <fonseca@diku.dk>,
Git Mailing List <git@vger.kernel.org>,
Timo Hirvonen <tihirvon@gmail.com>
Subject: Re: [PATCH] git-rev-list(1): group options; reformat; document more options
Date: Thu, 31 Aug 2006 17:06:54 -0700 [thread overview]
Message-ID: <7vsljc78m9.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0608311611440.27779@g5.osdl.org> (Linus Torvalds's message of "Thu, 31 Aug 2006 16:15:39 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> On Fri, 1 Sep 2006, Jonas Fonseca wrote:
>> Linus Torvalds <torvalds@osdl.org> wrote Thu, Aug 31, 2006:
>> >
>> > Umm? You should get a "usage" error, no?
>>
>> Yes, ok, they do not seem to make sense for git-rev-list, however if you
>> pass either to git-log, the output seems to make room for a diff, adding
>> one extra newline, but without appending any diff.
>
> Ahh. I think that a "-r" without any other request for patches (or
> "--name-status" or similar) should probably imply "--raw". At least that
> was how it historically worked..
>
> Anyway, _if_ it ever worked (and I think it did, but I'm way too lazy to
> bother checking), this may have been broken by the extensive diff option
> cleanups by Timo in June. Timo? Junio?
I think it did too. I am kind of surprised that nobody noticed
and t4013 test (which was done specifically to catch potential
behaviour change by Timo's patch) did not check for this
particular case.
next prev parent reply other threads:[~2006-09-01 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 22:37 [PATCH] git-rev-list(1): group options; reformat; document more options Jonas Fonseca
2006-08-31 23:02 ` Linus Torvalds
2006-08-31 23:08 ` Jonas Fonseca
2006-08-31 23:15 ` Linus Torvalds
2006-09-01 0:06 ` Junio C Hamano [this message]
2006-09-01 20:33 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsljc78m9.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=tihirvon@gmail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).