From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [WARNING] Please be careful when using "git add" from "next" branch
Date: Thu, 18 May 2006 01:52:44 -0700 [thread overview]
Message-ID: <7vsln74sv7.fsf_-_@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vwtcj4tp6.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Thu, 18 May 2006 01:34:45 -0700")
There is still a small breakage in the built-in "git add" on the
"next" branch that ends up creating nonsense tree objects.
$ mkdir foo
$ date >bar
$ git-add foo/../bar
$ git ls-files
foo/../bar
$ git ls-tree -r -t $(git-write-tree)
040000 tree ef5562cd3a9bf66d41a8d4f42f159e8c694ce7e3 foo
040000 tree 6e1612248e8da43fc5f91592e559da1ad5f9a852 foo/..
100644 blob 53ab446c3f4e42ce9bb728a0ccb283a101be4979 foo/../bar
If you do not do funky things like foo/../bar, I do not think
you have to worry, but scripted use might break. It used to
warn and ignore such bogus input, but now it happily accepts it
and produces bogus index which results in bogus trees.
"git update-index --add" is not affected by this breakage.
next prev parent reply other threads:[~2006-05-18 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 16:33 Do "git add" as a builtin Linus Torvalds
2006-05-17 19:06 ` Junio C Hamano
2006-05-17 20:23 ` Linus Torvalds
2006-05-18 8:13 ` Junio C Hamano
2006-05-18 8:34 ` Junio C Hamano
2006-05-18 8:52 ` Junio C Hamano [this message]
2006-05-19 6:28 ` FIXED: [WARNING] Please be careful when using "git add" from "next" branch Junio C Hamano
2006-05-18 15:26 ` Do "git add" as a builtin Linus Torvalds
2006-05-18 16:25 ` Linus Torvalds
2006-05-18 16:35 ` Linus Torvalds
2006-05-18 16:50 ` Junio C Hamano
2006-05-18 17:22 ` Linus Torvalds
2006-05-18 15:06 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsln74sv7.fsf_-_@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox