From: Junio C Hamano <gitster@pobox.com>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Matt Kraai <matt.kraai@amo.abbott.com>
Subject: Re: [PATCH] Allow building with xmlparse.h
Date: Mon, 11 Feb 2013 14:35:04 -0800 [thread overview]
Message-ID: <7vtxpijx7r.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1360621855-19863-1-git-send-email-kraai@ftbfs.org> (Matt Kraai's message of "Mon, 11 Feb 2013 14:30:55 -0800")
Matt Kraai <kraai@ftbfs.org> writes:
> From: Matt Kraai <matt.kraai@amo.abbott.com>
>
> expat 1.1 and 1.2 provide xmlparse.h instead of expat.h. Include the
> former on systems that define the EXPAT_NEEDS_XMLPARSE_H variable and
> define that variable on QNX systems, which ship with expat 1.1.
>
> Signed-off-by: Matt Kraai <matt.kraai@amo.abbott.com>
> ---
> Makefile | 6 ++++++
> config.mak.uname | 1 +
> http-push.c | 4 ++++
> 3 files changed, 11 insertions(+)
>
> I've changed #ifndef to #ifdef and changed the order of the branches
> in http-push.c. If you'd also like me to rename the variable (e.g.,
> to NEEDS_XMLPARSE_H), please let me know.
I do not think renaming is necessary (the name you used in the
original and this patch is better than NEEDS_XMLPARSE_H).
I take that you also think the updated order is easier to read;
thanks for sanity-checking ;-).
next prev parent reply other threads:[~2013-02-11 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 20:59 [PATCH] Include xmlparse.h instead of expat.h on QNX Matt Kraai
2013-02-11 21:06 ` Jeff King
2013-02-11 21:24 ` Matt Kraai
2013-02-11 22:03 ` [PATCH] Allow building with xmlparse.h Matt Kraai
2013-02-11 22:11 ` Junio C Hamano
2013-02-11 22:30 ` Matt Kraai
2013-02-11 22:35 ` Junio C Hamano [this message]
2013-02-11 21:41 ` [PATCH] Include xmlparse.h instead of expat.h on QNX Junio C Hamano
2013-02-11 21:34 ` Junio C Hamano
2013-02-11 21:49 ` Matt Kraai
2013-02-11 21:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtxpijx7r.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
--cc=matt.kraai@amo.abbott.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).