* [PATCH] Improve legibility of test_expect_code output
@ 2012-09-19 22:38 Adam Spiers
2012-09-20 0:06 ` Junio C Hamano
0 siblings, 1 reply; 9+ messages in thread
From: Adam Spiers @ 2012-09-19 22:38 UTC (permalink / raw)
To: git list
---
t/test-lib-functions.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
mode change 100644 => 100755 t/test-lib-functions.sh
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
old mode 100644
new mode 100755
index 8889ba5..e022e73
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -562,7 +562,7 @@ test_expect_code () {
return 0
fi
- echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
+ echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code from: $*"
return 1
}
--
1.7.12.147.g6d168f4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-19 22:38 [PATCH] Improve legibility of test_expect_code output Adam Spiers
@ 2012-09-20 0:06 ` Junio C Hamano
2012-09-20 0:25 ` Adam Spiers
0 siblings, 1 reply; 9+ messages in thread
From: Junio C Hamano @ 2012-09-20 0:06 UTC (permalink / raw)
To: Adam Spiers; +Cc: git list
Adam Spiers <git@adamspiers.org> writes:
> ---
No explanation why this is a good idea, nor sign-off?
> t/test-lib-functions.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 t/test-lib-functions.sh
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> old mode 100644
> new mode 100755
> index 8889ba5..e022e73
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -562,7 +562,7 @@ test_expect_code () {
> return 0
> fi
>
> - echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
> + echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code from: $*"
> return 1
> }
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 0:06 ` Junio C Hamano
@ 2012-09-20 0:25 ` Adam Spiers
2012-09-20 0:35 ` Junio C Hamano
2012-09-20 16:50 ` Junio C Hamano
0 siblings, 2 replies; 9+ messages in thread
From: Adam Spiers @ 2012-09-20 0:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git list
On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Adam Spiers <git@adamspiers.org> writes:
>
>> ---
>
> No explanation why this is a good idea, nor sign-off?
I realised I forgot the sign-off seconds after sending :-(
Isn't it completely self-explanatory? e.g.
test_expect_code: command exited with 0, we wanted 128 git foo bar
clearly makes more sense than
test_expect_code: command exited with 0, we wanted 128 from: git foo bar
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 0:25 ` Adam Spiers
@ 2012-09-20 0:35 ` Junio C Hamano
2012-09-20 0:48 ` Adam Spiers
2012-09-20 16:50 ` Junio C Hamano
1 sibling, 1 reply; 9+ messages in thread
From: Junio C Hamano @ 2012-09-20 0:35 UTC (permalink / raw)
To: Adam Spiers; +Cc: git list
Adam Spiers <git@adamspiers.org> writes:
> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Adam Spiers <git@adamspiers.org> writes:
>>
>>> ---
>>
>> No explanation why this is a good idea, nor sign-off?
>
> I realised I forgot the sign-off seconds after sending :-(
>
> Isn't it completely self-explanatory? e.g.
>
> test_expect_code: command exited with 0, we wanted 128 git foo bar
>
> clearly makes more sense than
>
> test_expect_code: command exited with 0, we wanted 128 from: git foo bar
If it were "..., we wanted 128 from 'git foo bar'", then I would,
but otherwise, not really.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 0:35 ` Junio C Hamano
@ 2012-09-20 0:48 ` Adam Spiers
0 siblings, 0 replies; 9+ messages in thread
From: Adam Spiers @ 2012-09-20 0:48 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git list
On Thu, Sep 20, 2012 at 1:35 AM, Junio C Hamano <gitster@pobox.com> wrote:
> If it were "..., we wanted 128 from 'git foo bar'", then I would,
> but otherwise, not really.
That's fine by me. Both are better than the status quo.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 0:25 ` Adam Spiers
2012-09-20 0:35 ` Junio C Hamano
@ 2012-09-20 16:50 ` Junio C Hamano
2012-09-20 16:57 ` Adam Spiers
1 sibling, 1 reply; 9+ messages in thread
From: Junio C Hamano @ 2012-09-20 16:50 UTC (permalink / raw)
To: Adam Spiers; +Cc: git list
Adam Spiers <git@adamspiers.org> writes:
> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Adam Spiers <git@adamspiers.org> writes:
>>
>>> ---
>>
>> No explanation why this is a good idea, nor sign-off?
>
> I realised I forgot the sign-off seconds after sending :-(
>
> Isn't it completely self-explanatory? e.g.
>
> test_expect_code: command exited with 0, we wanted 128 git foo bar
>
> clearly makes more sense than
>
> test_expect_code: command exited with 0, we wanted 128 from: git foo bar
test_expect_code: command exited with 0, we wanted 128: git foo bar
would be shorter and equally legible, I would think.
In any case, the proposed commit log message should have explained
these differences in the first place so that I or others do not have
to ask.
Do you want this queued on top of your other series, or as an
independent change?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 16:50 ` Junio C Hamano
@ 2012-09-20 16:57 ` Adam Spiers
2012-09-20 17:45 ` Junio C Hamano
0 siblings, 1 reply; 9+ messages in thread
From: Adam Spiers @ 2012-09-20 16:57 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git list
On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Do you want this queued on top of your other series, or as an
> independent change?
Independent please.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 16:57 ` Adam Spiers
@ 2012-09-20 17:45 ` Junio C Hamano
2012-09-20 18:05 ` Adam Spiers
0 siblings, 1 reply; 9+ messages in thread
From: Junio C Hamano @ 2012-09-20 17:45 UTC (permalink / raw)
To: Adam Spiers; +Cc: git list
Adam Spiers <git@adamspiers.org> writes:
> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Do you want this queued on top of your other series, or as an
>> independent change?
>
> Independent please.
With a sign-off?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Improve legibility of test_expect_code output
2012-09-20 17:45 ` Junio C Hamano
@ 2012-09-20 18:05 ` Adam Spiers
0 siblings, 0 replies; 9+ messages in thread
From: Adam Spiers @ 2012-09-20 18:05 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git list
On Thu, Sep 20, 2012 at 6:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Adam Spiers <git@adamspiers.org> writes:
>> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Do you want this queued on top of your other series, or as an
>>> independent change?
>>
>> Independent please.
>
> With a sign-off?
Yep.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-09-20 18:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-19 22:38 [PATCH] Improve legibility of test_expect_code output Adam Spiers
2012-09-20 0:06 ` Junio C Hamano
2012-09-20 0:25 ` Adam Spiers
2012-09-20 0:35 ` Junio C Hamano
2012-09-20 0:48 ` Adam Spiers
2012-09-20 16:50 ` Junio C Hamano
2012-09-20 16:57 ` Adam Spiers
2012-09-20 17:45 ` Junio C Hamano
2012-09-20 18:05 ` Adam Spiers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).