From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Sitaram Chamarty <sitaram@atc.tcs.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-difftool: allow skipping file by typing 'n' at prompt
Date: Tue, 04 Oct 2011 12:28:13 -0700 [thread overview]
Message-ID: <7vty7oblpu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CABURp0qmYWRJzHZZwZreKnj0ymFyM_AYXWXqwy=vTZspoPvvvg@mail.gmail.com> (Phil Hord's message of "Tue, 4 Oct 2011 14:02:54 -0400")
Phil Hord <phil.hord@gmail.com> writes:
> On Tue, Oct 4, 2011 at 11:25 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> I think I've seen this done as: "do this? [Y/n]" elsewhere.
>>
>> Not telling you what to do, but trying to feel what others may think.
>
> I think so, too. The [y]/n syntax is not clear enough for me to
> confidently know what the default value will be.
One downside of "do this [Y,n,m,o,p,q]? " is that it limits us to
lowercase responses, which means we cannot assign 'q' for quitting from
the innermost nested context and assign 'Q' for quitting from the whole
interactive loop (e.g. "git add -p").
"do this [y,n,m,o,p,q] (default=y)? "
may have been a better choice in hindsight.
No matter what we end up doing, let's try to be consistent.
Thanks.
next prev parent reply other threads:[~2011-10-04 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 10:53 [PATCH] git-difftool: allow skipping file by typing 'n' at prompt Sitaram Chamarty
2011-10-04 15:25 ` Junio C Hamano
2011-10-04 17:49 ` Jeff King
2011-10-04 18:02 ` Phil Hord
2011-10-04 19:28 ` Junio C Hamano [this message]
2011-10-04 23:05 ` Sitaram Chamarty
2011-10-06 12:56 ` Sitaram Chamarty
2011-10-06 17:36 ` Junio C Hamano
2011-10-06 18:15 ` Sitaram Chamarty
2011-10-07 20:09 ` Junio C Hamano
2011-10-08 13:10 ` Sitaram Chamarty
2011-10-09 11:26 ` Charles Bailey
2011-10-10 20:56 ` Junio C Hamano
2011-10-10 23:39 ` Sitaram Chamarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vty7oblpu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=phil.hord@gmail.com \
--cc=sitaram@atc.tcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).