From: Junio C Hamano <gitster@pobox.com>
To: Clemens Buchacher <drizzd@aon.at>
Cc: git@vger.kernel.org, tobiasu@tmux.org
Subject: Re: [PATCH 3/3] push: old receive-pack does not understand --quiet
Date: Tue, 06 Sep 2011 11:01:44 -0700 [thread overview]
Message-ID: <7vty8p8s8n.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1315067656-2846-4-git-send-email-drizzd@aon.at> (Clemens Buchacher's message of "Sat, 3 Sep 2011 18:34:16 +0200")
Clemens Buchacher <drizzd@aon.at> writes:
> Commit 90a6c7d4 (propagate --quiet to send-pack/receive-pack)
> introduced the --quiet option to receive-pack and made send-pack
> pass that option. Older versions of receive-pack do not recognize
> the option, however, and terminate immediately.
>
> This change restores backwards compatibility by adding a 'quiet'
> capability to receive-pack.
Wouldn't this mean that there is no point in adding --quiet command line
option to the receive-pack command? IOW, shouldn't parts of 90a6c7d
(propagate --quiet to send-pack/receive-pack, 2011-07-30) be reverted?
At this late stage in the release cycle, I would rather prefer to revert
the whole commit and leave anything new for the next cycle.
next prev parent reply other threads:[~2011-09-06 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 10:57 [BUG] git push --quiet fails with older versions Tobias Ulmer
2011-09-03 16:34 ` Clemens Buchacher
2011-09-03 16:34 ` [PATCH 1/3] tests for push --quiet Clemens Buchacher
2011-09-03 16:34 ` [PATCH 2/3] fix push --quiet via http Clemens Buchacher
2011-09-03 16:34 ` [PATCH 3/3] push: old receive-pack does not understand --quiet Clemens Buchacher
2011-09-05 2:28 ` Junio C Hamano
2011-09-05 3:01 ` Junio C Hamano
2011-09-05 8:35 ` Junio C Hamano
2011-09-05 9:23 ` Michael J Gruber
2011-09-05 14:17 ` Michael J Gruber
2011-09-05 14:24 ` [PATCH] t5541: avoid TAP test miscounting Michael J Gruber
2011-09-05 19:34 ` [PATCH 3/3] push: old receive-pack does not understand --quiet Junio C Hamano
2011-09-06 6:03 ` Michael J Gruber
2011-09-06 18:01 ` Junio C Hamano [this message]
2011-09-06 19:52 ` Clemens Buchacher
2011-09-04 12:08 ` [BUG] git push --quiet fails with older versions Tobias Ulmer
2011-09-04 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vty8p8s8n.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=tobiasu@tmux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).