From: Junio C Hamano <gitster@pobox.com>
To: kusmabite@gmail.com
Cc: Rafael Gieschke <rafael@gieschke.de>,
Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] compat: add a getpass() compatibility function
Date: Fri, 20 May 2011 10:18:17 -0700 [thread overview]
Message-ID: <7vtycp2sva.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BANLkTikRCXLJfOJFZ7j0TV_rxsySgQwSsw@mail.gmail.com> (Erik Faye-Lund's message of "Fri, 20 May 2011 12:48:28 +0200")
Erik Faye-Lund <kusmabite@gmail.com> writes:
> Actually, I'm thinking that we should avoid ever using getpass:
Good thinking.
> Instead,
> we should make our own function (based on your most recent patch?)
> that fills a caller-specified strbuf instead (git_getpass already have
> a static strbuf that we can fill).
Heh, I thought you earlier felt "a bit pointless" to "a properly
abstracted common version" I outlined earlier in the thread ;-)
next prev parent reply other threads:[~2011-05-20 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 11:37 [PATCH] compat: add a getpass() compatibility function Rafael Gieschke
2011-05-19 12:17 ` Erik Faye-Lund
2011-05-19 16:30 ` Junio C Hamano
2011-05-19 17:01 ` Rafael Gieschke
2011-05-19 17:27 ` Junio C Hamano
2011-05-19 18:07 ` Erik Faye-Lund
2011-05-19 19:16 ` Rafael Gieschke
2011-05-19 19:19 ` Erik Faye-Lund
2011-05-19 19:42 ` Rafael Gieschke
2011-05-19 20:12 ` Erik Faye-Lund
2011-05-19 21:16 ` Erik Faye-Lund
2011-05-20 10:06 ` Rafael Gieschke
2011-05-20 10:48 ` Erik Faye-Lund
2011-05-20 17:18 ` Junio C Hamano [this message]
2011-05-20 17:26 ` Erik Faye-Lund
2011-05-19 12:21 ` Erik Faye-Lund
2011-05-19 15:14 ` Jonathan Nieder
2011-05-19 15:29 ` Erik Faye-Lund
2011-05-19 17:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtycp2sva.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=rafael@gieschke.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).