From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] Add log.abbrevCommit config variable
Date: Tue, 17 May 2011 14:50:21 -0700 [thread overview]
Message-ID: <7vtyctf142.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vei3xgsy3.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 17 May 2011 10:03:48 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> But having slept on this, I would agree that it is a pragmatic solution to
> declare "pretty=raw _is_ special" and keep it that way. Let's queue v3
> from Jay and see what happens.
Having looked at this a bit more, there seems to be a special case in
cmd_log_reflog() that the command wants to default to abbrevCommit.
I haven't applied v3 (nor my fix-up in the discussion) yet, as this is not
my itch, but have you tested all commands from "log" family with your
patch, including "git reflog"?
next prev parent reply other threads:[~2011-05-17 21:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 17:22 [PATCH] Add log.abbrev-commit config option Jay Soffian
2011-05-14 17:26 ` Jay Soffian
2011-05-14 19:01 ` Jonathan Nieder
2011-05-14 19:35 ` Jay Soffian
2011-05-14 20:19 ` [PATCH] add, merge, diff: do not use strcasecmp to compare config variable names Jonathan Nieder
2011-05-15 1:53 ` Junio C Hamano
2011-05-14 20:47 ` [PATCH v2] Add log.abbrevCommit config variable Jay Soffian
2011-05-14 21:55 ` Jonathan Nieder
2011-05-14 22:22 ` Jay Soffian
2011-05-14 22:49 ` [PATCH v3] " Jay Soffian
2011-05-15 13:25 ` Jay Soffian
2011-05-15 22:42 ` Junio C Hamano
2011-05-16 5:53 ` Jay Soffian
2011-05-16 7:00 ` Jonathan Nieder
2011-05-16 7:18 ` Jay Soffian
2011-05-17 17:03 ` Junio C Hamano
2011-05-17 21:50 ` Junio C Hamano [this message]
2011-05-18 1:05 ` Jay Soffian
2011-05-17 18:50 ` Junio C Hamano
2011-05-17 19:08 ` Jay Soffian
2011-05-15 1:48 ` [PATCH] Add log.abbrev-commit config option Junio C Hamano
2011-05-16 8:24 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtyctf142.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).