From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Fredrik Gustafsson <iveqy@iveqy.com>, git@vger.kernel.org
Subject: Re: GSOC proposal
Date: Thu, 24 Mar 2011 16:47:41 -0700 [thread overview]
Message-ID: <7vtyes6pya.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4D8BD358.1030603@web.de> (Jens Lehmann's message of "Fri, 25 Mar 2011 00:27:20 +0100")
Jens Lehmann <Jens.Lehmann@web.de> writes:
>> == Preventing false "pointers" ==
>> It's far too easy to push a gitrepo pointing to a submodule version that
>> is not existing on the server. Prevent this by checking for available
>> submodule versions before acceptingt the push.
>
> Yes, requiring to force such a push is an issue raised quite often (I
> think addressing this issue would be a good starting point for people
> who want to get involved in enhancing the submodule experience).
You need to be careful, though.
That check can only be sanely done at a hosting site that hosts _both_ the
superproject and the submodule repositories. It might make more sense to
have this check on the side that pushes, which by definition should have
both superprojet and the submodule. Fail, or prompt to confirm, a push
from the superproject when it is detected that the submodule commits bound
to the commits in the superproject have not been pushed out.
> (And, as every year, it's a good idea for a prospective student to get
> involved in the git community before his application is accepted ...
> sending some patches is a good way to do that, maybe regarding one of
> the first two issues raised here? ;-)
While I agree that it is a good idea, I think the advice is about a few
weeks too late for this year already.
next prev parent reply other threads:[~2011-03-24 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 22:01 GSOC proposal Fredrik Gustafsson
2011-03-24 23:27 ` Jens Lehmann
2011-03-24 23:47 ` Junio C Hamano [this message]
2011-03-25 10:06 ` Fredrik Gustafsson
2011-03-25 23:07 ` Jens Lehmann
2011-03-25 10:08 ` Fredrik Gustafsson
[not found] <CAH-tXsAY0GErMAwi_TMaq0S4GuGx-OcPtEkJnXNqfGEyQq44_A@mail.gmail.com>
2012-03-27 12:47 ` GSOC Proposal Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2016-03-24 20:15 GSoC proposal work
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtyes6pya.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=iveqy@iveqy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).