git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, jrnieder@gmail.com
Subject: Re: [PATCH] Documentation/git-rebase: clarify -s option
Date: Fri, 12 Nov 2010 17:59:58 -0800	[thread overview]
Message-ID: <7vtyjmdlup.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1289588269-6920-1-git-send-email-martin.von.zweigbergk@gmail.com> (Martin von Zweigbergk's message of "Fri\, 12 Nov 2010 19\:57\:49 +0100")

Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:

> Clarify that it is '-s' itself that implies '--merge'. Currently it may
> seem like '--merge' is implied "If there is no `-s` option".
>
> Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
> ---
>  Documentation/git-rebase.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
> index 30e5c0e..f3753a8 100644
> --- a/Documentation/git-rebase.txt
> +++ b/Documentation/git-rebase.txt
> @@ -244,9 +244,9 @@ other words, the sides are swapped.
>  
>  -s <strategy>::
>  --strategy=<strategy>::
> -	Use the given merge strategy.
> +	Use the given merge strategy.  This implies --merge.
>  	If there is no `-s` option 'git merge-recursive' is used
> -	instead.  This implies --merge.
> +	instead.

The first change is absolutely right---thanks for starting this.  However,
"if there is no `-s`..." describes the default when `--merge` alone is
given, so these last two lines may need to move elsewhere, no?

      reply	other threads:[~2010-11-13  2:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 18:57 [PATCH] Documentation/git-rebase: clarify -s option Martin von Zweigbergk
2010-11-13  1:59 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtyjmdlup.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=martin.von.zweigbergk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).