From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] gitk: parse arbitrary commit-ish in SHA1 field Date: Mon, 10 Aug 2009 22:13:23 -0700 Message-ID: <7vtz0fndak.fsf@alter.siamese.dyndns.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Paul Mackerras , To: Thomas Rast X-From: git-owner@vger.kernel.org Tue Aug 11 14:15:39 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MaqGR-0000RC-7P for gcvg-git-2@gmane.org; Tue, 11 Aug 2009 14:15:39 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbZHKMGa (ORCPT ); Tue, 11 Aug 2009 08:06:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753175AbZHKMG3 (ORCPT ); Tue, 11 Aug 2009 08:06:29 -0400 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:43840 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbZHKMG2 (ORCPT ); Tue, 11 Aug 2009 08:06:28 -0400 Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 9A97E6FF8; Tue, 11 Aug 2009 01:13:28 -0400 (EDT) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id E8D2A6FF7; Tue, 11 Aug 2009 01:13:24 -0400 (EDT) User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-Pobox-Relay-ID: B46E7E68-8635-11DE-8C4C-EAC21EFB4A78-77302942!a-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Thomas Rast writes: > + } else { > + if {[catch {set id [exec git rev-parse $sha1string]}]} { "--verify", or "--no-flags --revs-only"? Examples of possible bad input strings that you may otherwise not catch are: master.. --merge -- a