From: Junio C Hamano <gitster@pobox.com>
To: rea-git@codelabs.ru
Cc: Junio C Hamano <gitster@pobox.com>,
normaperson@yhbt.net, git@vger.kernel.org
Subject: Re: [PATCH] git-svn testsuite: use standard configuration for Subversion tools
Date: Sat, 02 May 2009 04:56:28 -0700 [thread overview]
Message-ID: <7vtz437m6r.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <GzXVCxlG1vigUEGxhNBLVXNYljM@AnOk+mYbmYVORDu5SWQWxomMUcc> (Eygene Ryabinkin's message of "Sat\, 2 May 2009 14\:36\:29 +0400")
Eygene Ryabinkin <rea-git@codelabs.ru> writes:
>> > What are your concerns, 'local'?
>>
>> Exactly.
>
> It exists in Bash and in *BSD /bin/sh. It does not exist in Korn shell
> (at least, I am failing to find one). I can just remove 'local' from
> the function, since it plays no big role, but generally I don't like to
> pollute parent namespace by local variables. Certainly, if 'local' will
> break some known shell -- I'll refrain from using it in this script.
Yup, please. This is "it is not even in POSIX, so let's not use it"
category.
next prev parent reply other threads:[~2009-05-02 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 11:46 [PATCH] git-svn testsuite: use standard configuration for Subversion tools Eygene Ryabinkin
2009-05-01 18:26 ` Junio C Hamano
2009-05-01 19:10 ` Eygene Ryabinkin
2009-05-01 22:40 ` Junio C Hamano
2009-05-02 10:36 ` Eygene Ryabinkin
2009-05-02 11:56 ` Junio C Hamano [this message]
2009-05-04 13:05 ` Eygene Ryabinkin
2009-05-08 8:06 ` [RESEND PATCH] " Eygene Ryabinkin
2009-05-10 1:17 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtz437m6r.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=normaperson@yhbt.net \
--cc=rea-git@codelabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).