From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [RFCv3 1/2] gitweb: add patch view
Date: Fri, 05 Dec 2008 17:26:00 -0800 [thread overview]
Message-ID: <7vtz9iw0uv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200812060209.42906.jnareb@gmail.com> (Jakub Narebski's message of "Sat, 6 Dec 2008 02:09:42 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
> But we have also 'snapshot' feature, which like 'patches' is not simply
> on/off but is configurable feature, like 'patches' adds new action and
> does modify existing actions only by adding extra links... and which is
> enabled by default.
If my "git log" is telling the true story, "snapshot" was introduced in
cb9c6e5 (gitweb: Support for snapshot, 2006-08-17) and it was disabled by
default.
The "feature" mechanism was introduced after that, with ddb8d90 (gitweb:
Make blame and snapshot a feature., 2006-08-20). To avoid surprises,
"blame" were marked disabled by default to match the then-current default.
"snapshot" somehow ended up enabled with that change, though, which might
have been a mistake.
But "we erred before" is not a good excuse to deliberately err again, is
it?
next prev parent reply other threads:[~2008-12-06 1:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 22:59 [RFCv3 0/2] gitweb: patch view Giuseppe Bilotta
2008-12-03 22:59 ` [RFCv3 1/2] gitweb: add " Giuseppe Bilotta
2008-12-03 22:59 ` [RFCv3 2/2] gitweb: links to patch action in commitdiff and shortlog view Giuseppe Bilotta
2008-12-06 0:53 ` Jakub Narebski
2008-12-06 13:25 ` Giuseppe Bilotta
2008-12-06 15:25 ` Jakub Narebski
2008-12-03 23:55 ` [RFCv3 1/2] gitweb: add patch view Junio C Hamano
2008-12-04 0:20 ` Giuseppe Bilotta
2008-12-04 0:40 ` Junio C Hamano
2008-12-04 1:48 ` Jakub Narebski
2008-12-04 7:24 ` Giuseppe Bilotta
2008-12-06 0:34 ` Jakub Narebski
2008-12-06 0:46 ` Junio C Hamano
2008-12-06 1:09 ` Jakub Narebski
2008-12-06 1:26 ` Junio C Hamano [this message]
2008-12-06 13:01 ` Giuseppe Bilotta
2008-12-06 13:10 ` Petr Baudis
2008-12-06 12:34 ` Giuseppe Bilotta
2008-12-06 13:09 ` Jakub Narebski
2008-12-06 13:46 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtz9iw0uv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).