From: Junio C Hamano <gitster@pobox.com>
To: "Mikael Magnusson" <mikachu@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Matt McCutchen" <matt@mattmccutchen.net>,
git@vger.kernel.org
Subject: Re: [PATCH] "git diff <tree>{3,}": do not reverse order of arguments
Date: Sat, 11 Oct 2008 14:36:55 -0700 [thread overview]
Message-ID: <7vtzbiizk8.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 237967ef0810110553r662df370ud1ec34de402bfe1c@mail.gmail.com
"Mikael Magnusson" <mikachu@gmail.com> writes:
> 2008/10/11 Junio C Hamano <gitster@pobox.com>:
>> Perhaps the thinko was caused by discrepancy between the way internal
>> revision parser handles A..B and the way git-rev-parse parses it. While
>> the internal revision parser parses it into "A ^B", rev-parse gives them
>> in reverse order, i.e. "B ^A" (which is not going to change). In any
>> case, thanks for spotting this.
>
> Ehm, do you mean the internal parses it into "A ^B" and rev-parse gives "^B A"?
Sorry; a typo is in my description on the result from the internal parser.
For A..B, rev-parse gives B^ then A, and internal gives ^A in ent[0] and B
in ent[1].
prev parent reply other threads:[~2008-10-11 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 1:56 [PATCH] "git diff <tree>{3,}": do not reverse order of arguments Matt McCutchen
2008-10-11 11:29 ` Junio C Hamano
2008-10-11 12:53 ` Mikael Magnusson
2008-10-11 21:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzbiizk8.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=matt@mattmccutchen.net \
--cc=mikachu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).