From: Junio C Hamano <gitster@pobox.com>
To: Eric Hanchrow <offby1@blarg.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Note the use of "rebase -i" to squash consecutive commits into one.
Date: Mon, 18 Aug 2008 20:32:53 -0700 [thread overview]
Message-ID: <7vtzdhisre.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1219012340-23376-1-git-send-email-offby1@blarg.net> (Eric Hanchrow's message of "Sun, 17 Aug 2008 15:32:20 -0700")
This is missing sign-off.
More importantly, I do not think adding an extra illustration that starts
talking about an example history that is _different_ from what was being
discussed is a good idea. The end result lacks coherence and forces the
reader to reset his mind for each example.
I'd suggest you to rewrite the example part that begins a few lines before
you touched. Present the example "original" history with illustration
first (and call it A---B---C---D---E---F---G, not QRSTU), and clarify the
existing example of reordering the last 5 commits, and show the history
after such reordering.
Then you talk about squashing, with before-and-after illustrations, but
base that illustration on the same example history. That way, the reader
has to understand the original scene only once to grok both examples.
prev parent reply other threads:[~2008-08-19 3:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 22:32 [PATCH] Note the use of "rebase -i" to squash consecutive commits into one Eric Hanchrow
2008-08-19 3:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzdhisre.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=offby1@blarg.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox