From: Junio C Hamano <gitster@pobox.com>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
"Shawn O. Pearce" <spearce@spearce.org>,
Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH] builtin-name-rev: refactor stdin handling to its own function
Date: Fri, 01 Aug 2008 12:07:41 -0700 [thread overview]
Message-ID: <7vtze4sgea.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1217589372-4151-1-git-send-email-pdebie@ai.rug.nl> (Pieter de Bie's message of "Fri, 1 Aug 2008 13:16:12 +0200")
Pieter de Bie <pdebie@ai.rug.nl> writes:
> Signed-off-by: Pieter de Bie <pdebie@ai.rug.nl>
> ---
>
> On 1 aug 2008, at 09:23, Junio C Hamano wrote:
> >Is it just me to find that this part is getting indented too deeply to be
> >readable?
>
> How about something like this then?
Much nicer, except that this refactoring should come first and then a new
feature. Dropping those extra five 's' so that it would compile would be
a nice bonus as well ;-)
> ...
> +
> + if (name_only) {
> + fwrite(p_start, p - p_start + 1 - 40,
> + 1, stdout);sssss
> + printf(name);
> + }
next prev parent reply other threads:[~2008-08-01 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 13:20 [PATCH] git-name-rev: allow --name-only in combination with --stdin Pieter de Bie
2008-08-01 7:23 ` Junio C Hamano
2008-08-01 10:57 ` Johannes Schindelin
2008-08-01 11:16 ` [PATCH] builtin-name-rev: refactor stdin handling to its own function Pieter de Bie
2008-08-01 19:07 ` Junio C Hamano [this message]
2008-08-02 18:12 ` [PATCH] git-name-rev: allow --name-only in combination with --stdin Junio C Hamano
2008-08-03 13:44 ` [PATCH] git-name-rev: don't use printf without format René Scharfe
2008-08-03 20:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtze4sgea.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).