[PATCH 0/6] archive: refactor and cleanup

[PATCH 0/6] archive: refactor and cleanup

[René Scharfe]

This series is a collection of cleanups for git archive that I finally need
to get out, reviewed and (hopefully!) integrated.  It should make adding
more format backends easier.

Patch 2 adds a context parameter to read_tree_recursive(), thus affecting
all its callers.  The rest of the patches change *archive*.[ch], only.

René



 archive-tar.c             |  115 ++++++++++++---------------------------
 archive-zip.c             |  102 +++++------------------------------
 archive.c                 |  132 ++++++++++++++++++++++++++++++++------------
 archive.h                 |   15 ++----
 builtin-archive.c         |   75 ++++++++++++--------------
 builtin-checkout.c        |    4 +-
 builtin-log.c             |    4 +-
 builtin-ls-tree.c         |    4 +-
 builtin-merge-recursive.c |    4 +-
 builtin-upload-archive.c  |   11 ++--
 tree.c                    |   12 ++--
 tree.h                    |    4 +-
 12 files changed, 208 insertions(+), 274 deletions(-)

Re: [PATCH 0/6] archive: refactor and cleanup

[Lea Wiemann]

René Scharfe wrote:
> This series is a collection of cleanups for git archive

A few things:

* The note quoted above probably shouldn't be in the commit message but
after the "---".

* You patch messages seem to be In-Reply-To a message that wasn't posted
on the list, not to PATCH 0/6.

* Unless you have a specific reason, I suggest that you don't Cc Junio
on patches; he reads all messages on this list (more or less) and will
usually simply apply your patches once they're reviewed.  (Watch for his
periodical "What's cooking in git.git" messages to see if he got them.)

* And most importantly, your Thunderbird introduced line-breaks, so it's
not possible to apply the patches.  May I suggest you use git-send-email
instead?

Feel free to ping me on IRC (lea_w in #git) if you need help.

Re: [PATCH 0/6] archive: refactor and cleanup

[Lea Wiemann]

Lea Wiemann wrote:
> * Unless you have a specific reason, I suggest that you don't Cc Junio
> on patches; he reads all messages on this list (more or less) and will
> usually simply apply your patches once they're reviewed.  (Watch for his
> periodical "What's cooking in git.git" messages to see if he got them.)

Uh, I just noticed that you have enough commits in git.git that you
probably didn't need this lecture. ;-)  Sorry, Rene.  (Thanks Dscho for
the pointer.)

Re: [PATCH 0/6] archive: refactor and cleanup

[René Scharfe]

Lea Wiemann schrieb:
> René Scharfe wrote:
>> This series is a collection of cleanups for git archive
> 
> A few things:
> 
> * The note quoted above probably shouldn't be in the commit message but
> after the "---".

Since it's in the zeroth message, it's not intended to be committed.

> * You patch messages seem to be In-Reply-To a message that wasn't posted
> on the list, not to PATCH 0/6.

Hmm, that's strange.  Won't happen next time, though.

> * Unless you have a specific reason, I suggest that you don't Cc Junio
> on patches; he reads all messages on this list (more or less) and will
> usually simply apply your patches once they're reviewed.  (Watch for his
> periodical "What's cooking in git.git" messages to see if he got them.)

We're both wrong, quoth Documentation/SubmittingPatches:

    Note that your maintainer does not necessarily read everything
    on the git mailing list.  If your patch is for discussion first,
    send it "To:" the mailing list, and optionally "cc:" him.  If it
    is trivially correct or after the list reached a consensus, send
    it "To:" the maintainer and optionally "cc:" the list.

Obviously, my patches weren't trivially correct nor a consensus reached.

> * And most importantly, your Thunderbird introduced line-breaks, so it's
> not possible to apply the patches.  May I suggest you use git-send-email
> instead?

Well, it is possible to send usable patches with Thunderbird, using the
extension Toggle Word Wrap.  Patches 1 and 3 are damaged because I
edited them again to correct a typo -- with word wrap accidentally on.

Trying git-send-email again is a good idea, though.

> Feel free to ping me on IRC (lea_w in #git) if you need help.

I've slacked long enough to become a complete noob again.  Oh, well.

Thanks,
René

Re: [PATCH 0/6] archive: refactor and cleanup

[Junio C Hamano]

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Lea Wiemann schrieb:
> ...
>> Feel free to ping me on IRC (lea_w in #git) if you need help.
>
> I've slacked long enough to become a complete noob again.  Oh, well.

Lol ;-)

The series looks good.  Thanks.