git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Eric Raible <raible@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] bash: offer only paths after '--'
Date: Tue, 08 Jul 2008 13:21:35 -0700	[thread overview]
Message-ID: <7vtzf0rusw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080708165614.GB8224@neumann> (SZEDER Gábor's message of "Tue, 8 Jul 2008 18:56:14 +0200")

SZEDER Gábor <szeder@ira.uka.de> writes:

> Hope that I got the commit message right (;

It was very readable.  Thanks.

> +__git_has_doubledash ()
> +{
> +	local c=1
> +	while [ $c -lt $COMP_CWORD ]; do
> +		if [ "--" = "${COMP_WORDS[c]}" ]; then
> +			return 0
> +		fi
> +		c=$((++c))

This assignment is somewhat curious, although it should work as expected
either way ;-)

Shawn?

  parent reply	other threads:[~2008-07-08 20:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07 20:41 [PATCH] completion: add branch options --contains --merged --no-merged Eric Raible
2008-07-08  4:49 ` Shawn O. Pearce
2008-07-08  5:30   ` Junio C Hamano
2008-07-08 11:36     ` Johannes Schindelin
2008-07-08 16:56       ` [PATCH] bash: offer only paths after '--' SZEDER Gábor
2008-07-08 17:46         ` Eric Raible
2008-07-08 20:21         ` Junio C Hamano [this message]
2008-07-08 23:18           ` Shawn O. Pearce
2008-07-08 23:23             ` Junio C Hamano
2008-07-08 23:51             ` SZEDER Gábor
2008-07-08 23:55               ` Shawn O. Pearce
2008-07-09  0:06               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtzf0rusw.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=raible@gmail.com \
    --cc=spearce@spearce.org \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).