From: Junio C Hamano <gitster@pobox.com>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-fast-export: Remove double spaces in author line
Date: Fri, 30 May 2008 13:27:37 -0700 [thread overview]
Message-ID: <7vtzgfk05i.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1212143475-48255-1-git-send-email-pdebie@ai.rug.nl
Pieter de Bie <pdebie@ai.rug.nl> writes:
> It produces
>
> "author Samba Release Account <samba-bugs@samba.org> 831196245 +0000"
>
> The git-fast-import syntax says there can only be a single space after the >
> sign. This Samba commit breaks bzr-fast-import, for example.
>
> I'm not sure how to properly fix the problem, as I'm not very deep into Git's
> code. I included this patch in case anyone else has the same problem and wants
> a quick fix. I'm also not sure if it's a fast-export problem, or if the Samba
> repository is just invalid :)
You can call that repository broken if you want, but we can try to be
liberal when receiving and be strict when generating. IOW, fast-import
could accept such a minor deviation and generate a commit after fixing it.
The same thing can be said about fast-export --- read, fix and generate.
By the way, your quick hack would however squash multiple SPs anywhere on
the line, wouldn't it, not just the one between '>' and the timestamp?
prev parent reply other threads:[~2008-05-30 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 10:31 [PATCH] builtin-fast-export: Remove double spaces in author line Pieter de Bie
2008-05-30 20:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzgfk05i.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).