From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org
Subject: Re: [PATCH 11/11] Support bundles in builtin-clone
Date: Sun, 09 Mar 2008 23:32:38 -0700 [thread overview]
Message-ID: <7vtzjfks1l.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7v7igbm8cb.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 09 Mar 2008 22:55:16 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> Of course, I am okay with it, but I consider the From: issue a real bug in
>> send-email (or format-patch, if you want).
>
> Format-patch is about recording the author of the patch on From: line
> (think of it a tool to reproduce an e-mail that you would have received
> and applied to your tree). It may probably make a lot of sense to teach
> send-email not to forge From: (even though, RFC is Ok with it, as long as
> it also correctly adds Sender: pointing at the real sender).
Well, as I re-read send-email, it does put you on the From: and adds the
patch author From: at the beginning of the message. So there is no bug
here. Daniel did not use send-email, so of course even if there were a
bug in send-email it would not have triggered ;-)
So there is no bug to hunt here.
next prev parent reply other threads:[~2008-03-10 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 23:04 [PATCH 11/11] Support bundles in builtin-clone Johannes Schindelin
2008-03-08 23:28 ` Johannes Schindelin
2008-03-09 19:00 ` Daniel Barkalow
2008-03-09 20:56 ` Johannes Schindelin
2008-03-09 21:59 ` Daniel Barkalow
2008-03-10 5:55 ` Junio C Hamano
2008-03-10 6:32 ` Junio C Hamano [this message]
2008-03-10 10:56 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzjfks1l.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).