[PATCH] receive-pack: Initialize PATH to include exec-dir.

[PATCH] receive-pack: Initialize PATH to include exec-dir.

[Björn Steinbrink]

511707d (use only the $PATH for exec'ing git commands) made it a
requirement to call setup_path() to include the git exec-dir in PATH
before spawning any other git commands. git-receive-pack was not yet
adapted to do this and therefore fails to spawn git-unpack-objects if that
is not in the standard PATH.

Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
---
 receive-pack.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/receive-pack.c b/receive-pack.c
index a971433..f83ae87 100644
--- a/receive-pack.c
+++ b/receive-pack.c
@@ -471,6 +471,8 @@ int main(int argc, char **argv)
 	if (!dir)
 		usage(receive_pack_usage);
 
+	setup_path(NULL);
+
 	if (!enter_repo(dir, 0))
 		die("'%s': unable to chdir or not a git archive", dir);
 
-- 
1.5.4.3.1.g3b5b4

Re: [PATCH] receive-pack: Initialize PATH to include exec-dir.

[Bernt Hansen]

Björn Steinbrink <B.Steinbrink@gmx.de> writes:

> 511707d (use only the $PATH for exec'ing git commands) made it a
> requirement to call setup_path() to include the git exec-dir in PATH
> before spawning any other git commands. git-receive-pack was not yet
> adapted to do this and therefore fails to spawn git-unpack-objects if that
> is not in the standard PATH.
>
> Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
> ---
>  receive-pack.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/receive-pack.c b/receive-pack.c
> index a971433..f83ae87 100644
> --- a/receive-pack.c
> +++ b/receive-pack.c
> @@ -471,6 +471,8 @@ int main(int argc, char **argv)
>  	if (!dir)
>  		usage(receive_pack_usage);
>  
> +	setup_path(NULL);
> +
>  	if (!enter_repo(dir, 0))
>  		die("'%s': unable to chdir or not a git archive", dir);
>  
> -- 
> 1.5.4.3.1.g3b5b4
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tested by: Bernt Hansen <bernt@norang.ca>

Re: [PATCH] receive-pack: Initialize PATH to include exec-dir.

[Junio C Hamano]

I think this is a sensible companion patch to the earlier 04b3305
(upload-pack: Initialize the exec-path.).  We should have done this back
then.

Thanks.