* [PATCH] receive-pack: Initialize PATH to include exec-dir.
@ 2008-03-03 4:08 Björn Steinbrink
2008-03-03 4:21 ` Bernt Hansen
2008-03-03 4:58 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Björn Steinbrink @ 2008-03-03 4:08 UTC (permalink / raw)
To: gitster; +Cc: srp, git
511707d (use only the $PATH for exec'ing git commands) made it a
requirement to call setup_path() to include the git exec-dir in PATH
before spawning any other git commands. git-receive-pack was not yet
adapted to do this and therefore fails to spawn git-unpack-objects if that
is not in the standard PATH.
Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
---
receive-pack.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/receive-pack.c b/receive-pack.c
index a971433..f83ae87 100644
--- a/receive-pack.c
+++ b/receive-pack.c
@@ -471,6 +471,8 @@ int main(int argc, char **argv)
if (!dir)
usage(receive_pack_usage);
+ setup_path(NULL);
+
if (!enter_repo(dir, 0))
die("'%s': unable to chdir or not a git archive", dir);
--
1.5.4.3.1.g3b5b4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] receive-pack: Initialize PATH to include exec-dir.
2008-03-03 4:08 [PATCH] receive-pack: Initialize PATH to include exec-dir Björn Steinbrink
@ 2008-03-03 4:21 ` Bernt Hansen
2008-03-03 4:58 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Bernt Hansen @ 2008-03-03 4:21 UTC (permalink / raw)
To: Björn Steinbrink; +Cc: gitster, srp, git
Björn Steinbrink <B.Steinbrink@gmx.de> writes:
> 511707d (use only the $PATH for exec'ing git commands) made it a
> requirement to call setup_path() to include the git exec-dir in PATH
> before spawning any other git commands. git-receive-pack was not yet
> adapted to do this and therefore fails to spawn git-unpack-objects if that
> is not in the standard PATH.
>
> Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
> ---
> receive-pack.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/receive-pack.c b/receive-pack.c
> index a971433..f83ae87 100644
> --- a/receive-pack.c
> +++ b/receive-pack.c
> @@ -471,6 +471,8 @@ int main(int argc, char **argv)
> if (!dir)
> usage(receive_pack_usage);
>
> + setup_path(NULL);
> +
> if (!enter_repo(dir, 0))
> die("'%s': unable to chdir or not a git archive", dir);
>
> --
> 1.5.4.3.1.g3b5b4
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Tested by: Bernt Hansen <bernt@norang.ca>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] receive-pack: Initialize PATH to include exec-dir.
2008-03-03 4:08 [PATCH] receive-pack: Initialize PATH to include exec-dir Björn Steinbrink
2008-03-03 4:21 ` Bernt Hansen
@ 2008-03-03 4:58 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-03-03 4:58 UTC (permalink / raw)
To: Björn Steinbrink; +Cc: srp, git, Johannes Sixt
I think this is a sensible companion patch to the earlier 04b3305
(upload-pack: Initialize the exec-path.). We should have done this back
then.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-03 5:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-03 4:08 [PATCH] receive-pack: Initialize PATH to include exec-dir Björn Steinbrink
2008-03-03 4:21 ` Bernt Hansen
2008-03-03 4:58 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).