Re: [PATCH] gitweb: Change feeds from commit to commitdiff output.

[Junio C Hamano <gitster@pobox.com>]

Florian La Roche <laroche@redhat.com> writes:

> [PATCH] gitweb: Change feeds from commit to commitdiff output.
>
> Change feeds from displaying the commit to displaying the commitdiff
> output. This way the patches are shown directly and code review is
> done more easily via watching feeds.
>
> Signed-off-by: Florian La Roche <laroche@redhat.com>

I can see that easier access to commitdiff output is sometimes
desirable.

If you are making this change unconditional, however, I think
there needs a list discussion between you and the silent
majority of people that have been perfectly happy with the
current "log only" behaviour.

And to have that discussion, you first have to wake them up,
which this patch would serve well as a wake-up call.  But if
that was the purpose of the posting, please (1) mark the patch
as such (commonly done by saying [RFC/PATCH] instead), and (2)
keep me out of the "To:" list, if the patch is not for inclusion
but for discussion ("cc:" is fine but it's redundant as long as
you are sending to the list).

After such a discussion, we may end up finding out that
everybody have been silently unhappy and wanted to have
commitdiff there, and agree on doing this unconditionally.

But we do not know that yet.

Thanks.