From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: FLEX_ARRAY=1 causes SIGSEGV on SPARC
Date: Mon, 17 Dec 2007 17:08:44 -0800 [thread overview]
Message-ID: <7vtzmg3j37.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071218010126.GP14735@spearce.org> (Shawn O. Pearce's message of "Mon, 17 Dec 2007 20:01:26 -0500")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> I'll try to track it down tomorrow. But the immediate workaround was
> to just add '-DFLEX_ARRAY=/* empty */' to my CFLAGS and recompile
> the world. This compiler accepts the empty FLEX_ARRAY macro but
> I'm not sure what feature test(s) would be necessary to make Git
> able to automatically set that, seeing as how the tests defined in
> 8e97 are perfectly reasonable and didn't pass.
> ..., but will try to come up with a reasonable
> detection patch....
Actually I would be more worried about the breakage in FLEX_ARRAY=1 case
than misdetection. Even if your compiler supports the flexible array
members, the fallback to FLEX_ARRAY=1 ought to work and you are seeing a
case where it doesn't.
next prev parent reply other threads:[~2007-12-18 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 1:01 FLEX_ARRAY=1 causes SIGSEGV on SPARC Shawn O. Pearce
2007-12-18 1:08 ` Junio C Hamano [this message]
2007-12-18 1:32 ` [PATCH] diff-delta.c: make FLEX_ARRAY=1 work David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzmg3j37.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).