From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, krh@redhat.com, gitster@pobox.com
Subject: Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created
Date: Sun, 02 Dec 2007 10:34:49 -0800 [thread overview]
Message-ID: <7vtzn1x7w6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0712021716220.27959@racer.site> (Johannes Schindelin's message of "Sun, 2 Dec 2007 17:18:24 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> I have made several attempts to reproduce the problem, looked a bit
>> through the log-tree code, and checked the results of the t750* series
>> of tests; but I have found nothing.
>
> I remember again. When I did "commit -s -m bla" the empty line between
> the oneline and the signoff would be missing. But in the meantime, the
> signoff was dragged into the strbuf and all is well.
Sorry, now I am confused. Building the version before that change and
doing "./git-commit -a -s -m bla", I do not see the extra blank line in
the "Created commit" response, and I see a blank line before and after
the sign-off in the "git show" output for the resulting commit.
Was this unnecessary change from the beginning? I am inclined to think
so...
next prev parent reply other threads:[~2007-12-02 18:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 17:35 [PATCH 0/6] Various (replacement) patches to builtin-commit Johannes Schindelin
2007-11-11 17:35 ` [PATCH 1/6] builtin-commit: fix author date with --amend --author=<author> Johannes Schindelin
2007-11-12 19:38 ` Kristian Høgsberg
2007-11-12 20:12 ` Johannes Schindelin
2007-11-13 0:37 ` Junio C Hamano
2007-11-11 17:35 ` [PATCH 2/6] git status: show relative paths when run in a subdirectory Johannes Schindelin
2007-11-11 17:35 ` [PATCH 3/6] builtin-commit: fix --signoff Johannes Schindelin
2007-11-11 17:36 ` [PATCH 4/6] builtin-commit --s: add a newline if the last line was no S-O-B Johannes Schindelin
2007-11-11 17:36 ` [PATCH 5/6] builtin-commit: resurrect behavior for multiple -m options Johannes Schindelin
2007-11-11 19:42 ` Pierre Habouzit
2007-11-11 20:42 ` Johannes Schindelin
2007-11-11 22:11 ` Pierre Habouzit
2007-11-11 22:13 ` Pierre Habouzit
2007-11-11 17:36 ` [PATCH 6/6] builtin-commit: Add newline when showing which commit was created Johannes Schindelin
2007-12-01 22:21 ` Jeff King
2007-12-01 22:41 ` Johannes Schindelin
2007-12-02 5:40 ` Jeff King
2007-12-02 12:13 ` Johannes Schindelin
2007-12-02 16:54 ` Jeff King
2007-12-02 17:18 ` Johannes Schindelin
2007-12-02 18:34 ` Junio C Hamano [this message]
2007-12-02 21:20 ` Johannes Schindelin
2007-12-03 7:33 ` Junio C Hamano
2007-12-03 7:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzn1x7w6.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).