From: Junio C Hamano <gitster@pobox.com>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites.
Date: Fri, 02 Nov 2007 13:09:56 -0700 [thread overview]
Message-ID: <7vtzo41ka3.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1194017589-4669-2-git-send-email-krh@redhat.com> (Kristian Høgsberg's message of "Fri, 2 Nov 2007 11:33:07 -0400")
Kristian Høgsberg <krh@redhat.com> writes:
> Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> ---
> t/t3501-revert-cherry-pick.sh | 4 ++--
> t/t3901-i18n-patch.sh | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
This is a good patch, but a real commit message that says why
they are unnecessary is lacking. Something like...
Sourcing of ./test-lib.sh at the very beginning of test scripts
already define and export them.
next prev parent reply other threads:[~2007-11-02 20:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 15:33 [PATCH 1/4] Add testcase for ammending and fixing author in git commit Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor Kristian Høgsberg
2007-11-02 15:33 ` [PATCH 4/4] Implement git commit and status as a builtin commands Kristian Høgsberg
2007-11-03 13:56 ` Johannes Schindelin
2007-11-08 16:01 ` Kristian Høgsberg
2007-11-03 15:06 ` Björn Steinbrink
2007-11-05 18:57 ` Kristian Høgsberg
2007-11-05 19:23 ` Björn Steinbrink
2007-11-05 23:18 ` Johannes Schindelin
2007-11-06 6:59 ` Björn Steinbrink
2007-11-06 16:46 ` Kristian Høgsberg
2007-11-06 17:08 ` Björn Steinbrink
2007-11-06 9:12 ` Pierre Habouzit
2007-11-06 9:18 ` Johannes Sixt
2007-11-06 9:26 ` Pierre Habouzit
2007-11-06 9:47 ` Andreas Ericsson
2007-11-06 16:42 ` Kristian Høgsberg
2007-11-02 15:46 ` [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor Andreas Ericsson
2007-11-02 16:16 ` Kristian Høgsberg
2007-11-02 20:09 ` Junio C Hamano [this message]
2007-11-02 20:07 ` [PATCH 1/4] Add testcase for ammending and fixing author in git commit Junio C Hamano
2007-11-02 21:13 ` Kristian Høgsberg
2007-11-02 22:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzo41ka3.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).