From: Junio C Hamano <gitster@pobox.com>
To: "David Symonds" <dsymonds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix documentation for core.gitproxy to reflect code
Date: Thu, 02 Aug 2007 13:12:31 -0700 [thread overview]
Message-ID: <7vtzrhvgpc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <ee77f5c20708020523m1a243bf2g9778994441cd21d5@mail.gmail.com> (David Symonds's message of "Thu, 2 Aug 2007 22:23:34 +1000")
"David Symonds" <dsymonds@gmail.com> writes:
> This is with respect to my earlier email about core.gitproxy. I
> figured since 1.5.3 is looming it would be best to get the
> documentation correct, then nag about the feature later!
>
> Dave.
That's not a commit log message.
If the existing example does not work, then please say that you
fixed it (i.e. "The values in the example does not work. The
accepted forms are such and such and such, so use them in the
example") in the log message. "Your earlier email" does not
count. People who are reading the "git log" output would not
have easy access to it.
If core.gitproxy is not documented (I suspect the parts you
touched are not about "how to use core.gitproxy" but "what's the
syntax of a configuration file" example), it needs its own
proper entry in config.txt. If it has one, but if you feel it
needs more explanation or exmples, that section needs to be
updated.
Please retry.
next prev parent reply other threads:[~2007-08-02 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 12:23 [PATCH] Fix documentation for core.gitproxy to reflect code David Symonds
2007-08-02 20:12 ` Junio C Hamano [this message]
2007-08-02 22:45 ` David Symonds
2007-08-02 23:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzrhvgpc.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=dsymonds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox