From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Tjernlund <tjernlund@tjernlund.se>
Subject: Re: Fix zero-object version-2 packs
Date: Tue, 26 Jun 2007 17:41:46 -0700 [thread overview]
Message-ID: <7vtzsuw7n9.fsf@assigned-by-dhcp.pobox.com> (raw)
In-Reply-To: alpine.LFD.0.98.0706261428420.8675@woody.linux-foundation.org
Linus Torvalds <torvalds@linux-foundation.org> writes:
> A pack-file can get created without any objects in it (to transfer "no
> data" - which can happen if you use a reference git repo, for example,
> or just otherwise just end up transferring only branch head information
> and already have all the objects themselves).
>
> And while we probably should never create an index for such a pack, if we
> do (and we do), the index file size sanity checking was incorrect.
>
> This fixes it.
>
> Reported-and-tested-by: Jocke Tjernlund <tjernlund@tjernlund.se>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>
> Tjernlund <tjernlund@tjernlund.se> wrote:
>>
>> [SNIP patch]
>>
>> Tested your patch and the error went away, many thanks
Thank you very much to both of you. Will be in 'maint'.
prev parent reply other threads:[~2007-06-27 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 21:34 Fix zero-object version-2 packs Linus Torvalds
2007-06-27 0:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtzsuw7n9.fsf@assigned-by-dhcp.pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tjernlund@tjernlund.se \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox