From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: Fix silly typo in new builtin grep
Date: Mon, 15 May 2006 20:18:11 -0700 [thread overview]
Message-ID: <7vu07qfyj0.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0605151743360.3866@g5.osdl.org> (Linus Torvalds's message of "Mon, 15 May 2006 17:54:01 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> The "-F" flag apparently got mis-translated due to some over-eager
> copy-paste work into a duplicate "-H" when using the external grep.
Thanks. I've pushed it out to "master", along with some other
stuff.
> Me likee the new built-in grep. The ability to say
>
> git grep __make_request v2.6.13 -- '*.c'
>
> to grep for it in a specific version is well worth the fact that it
> obviously ends up being slower than grepping in the currently checked-out
> tree. It's doing a hell of a lot more, but despite that it's not at all
> that slow.
>
> (In fact, I would say that doing the above command in just 4 seconds is
> damn impressive - it's a large code-base, and v2.6.13 is several months,
> and over 20 _thousand_ revisions ago).
That is a BS praise and you know it ;-). You do not have delta
chains that are 20k long, so grepping from the tree 10 revs ago
and from the tree 20k revs ago would not make a difference.
It _would_ be impressive to CVS folks, but even there each path
would not have 20k revisions. The kernel patches tend to touch
3 paths per patch on average, so 60k changes over 18k files
distributed unevenly -- my guess (I could count but haven't) is
probably 200 revisions at most for most frequently touched file.
next prev parent reply other threads:[~2006-05-16 3:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 0:54 Fix silly typo in new builtin grep Linus Torvalds
2006-05-16 1:07 ` Linus Torvalds
2006-05-16 2:10 ` Morten Welinder
2006-05-16 3:27 ` Linus Torvalds
2006-05-16 3:18 ` Junio C Hamano [this message]
2006-05-16 3:32 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vu07qfyj0.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox