From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: Please undo "Use git-merge instead of git-resolve in git-pull"
Date: Wed, 21 Sep 2005 14:48:46 -0700 [thread overview]
Message-ID: <7vu0genlc1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0509211310150.2553@g5.osdl.org> (Linus Torvalds's message of "Wed, 21 Sep 2005 13:15:39 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> Local changes are a problem ONLY IF THOSE LOCAL CHANGES INTERFERE WITH THE
> MERGE.
True, sorry, and reverted.
* Regardless of whatever else, we could detect when there is
only one strategy applicable and bypass that check -- "reset
--hard" should never happen in that case and 'git pull -s
stupid' would regain the traditional behaviour and we should
probably make this the default for 'git pull'.
* Otherwise, if the user wants it to try multiple strategies, we
need to detect the local changes in the tree that _could_
interfere with the merge more precisely.
In order for that, we need to have a way to figure out the set
of paths that _could_ potentially be involved in the merge.
Once we have that set, we can just check if we have local
changes on those paths, and the "restoring to the pre-merge
state" currently done with "reset --hard" kludge could just
restore those paths from the pre-merge HEAD.
This is however harder than it sounds once we start allowing
renaming merges. If the ancestor had A/foo, you kept it and
have an addition of A/bar as a local change, and the head that
is being merged renames stuff in A/ to B/A/, it is more likely
than not that you would want to have A/bar moved to B/A/bar in
your merge result. Once we go this route, the only thing it
makes sense would be to make it responsibility for each merge
strategy to preserve before starting its work and to restore
after it has failed.
* I thought you do not multitask and wonder why you are merging
while you still have local changes, but that does not justify
this regression.
next prev parent reply other threads:[~2005-09-21 21:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-21 20:15 Please undo "Use git-merge instead of git-resolve in git-pull" Linus Torvalds
2005-09-21 20:20 ` Linus Torvalds
2005-09-21 21:48 ` Junio C Hamano [this message]
2005-09-21 22:03 ` Linus Torvalds
2005-09-22 0:28 ` David S. Miller
2005-09-22 0:39 ` Linus Torvalds
2005-09-22 0:54 ` Olivier Galibert
2005-09-22 1:46 ` Martin Langhoff
2005-09-22 2:10 ` Linus Torvalds
2005-09-23 0:28 ` Petr Baudis
-- strict thread matches above, loose matches on Subject: below --
2005-09-22 16:31 Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vu0genlc1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).