From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: promote wildmatch to be the default fnmatch implementation
Date: Wed, 29 May 2013 19:25:39 -0700 [thread overview]
Message-ID: <7vvc61p5jw.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1369877684-5050-1-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Thu, 30 May 2013 08:34:44 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> This makes git use wildmatch by default for all fnmatch() calls. Users
> who want to use system fnmatch (or compat fnmatch) need to set
> NO_WILDMATCH flag.
>
> wildmatch is a drop-in fnmatch replacement with more features. Using
> wildmatch gives us a consistent behavior across platforms.
Hmph, could you (no need to hurry, though) check the previous
discussion and point at what we decided if we did reach any
conclusion to refresh our collective memory?
While I agree this is a good move in the longer term in that we get
the often-asked-for "foo/**/*.c" match and also we have one less
platform differences to worry about, I somehow have a recollection
that we discussed that there are incompatibilities in dark corners
we would want to warn users about and lay a transition plan across
some major version bump.
Thanks.
next prev parent reply other threads:[~2013-05-30 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 1:34 [PATCH] Makefile: promote wildmatch to be the default fnmatch implementation Nguyễn Thái Ngọc Duy
2013-05-30 2:25 ` Junio C Hamano [this message]
2013-05-30 11:37 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvc61p5jw.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox