From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] git-tag(1): we tag HEAD by default
Date: Wed, 03 Apr 2013 08:17:00 -0700 [thread overview]
Message-ID: <7vvc8363v7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <877gkjvecg.fsf@linux-k42r.v.cablecom.net> (Thomas Rast's message of "Wed, 3 Apr 2013 17:11:27 +0200")
Thomas Rast <trast@inf.ethz.ch> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Thomas Rast <trast@inf.ethz.ch> writes:
>>
>>> +<commit>, <object>::
>>> + The object that the new tag will refer to, usually a commit.
>>> + Defaults to HEAD.
>>
>> Shouldn't this be more like this:
>>
>> <commit>::
>> <object>::
>> Your explanation here...
>
> Hmm, you're right, but we seem to be fairly inconsistent in that
> department. There are some instances with the comma style:
That is because we did not know better in the olden days, until
somebody noticed and started using the separate-line form. We might
have a patch or two to only convert from the comma-style but I do
not recall us doing a whole-tree style clean-ups.
> Should we fix that?
I personally do not think the churn is warranted. "Fix the existing
ones you notice as you touch the vicinity, and avoid introducing new
ones" is good enough.
next prev parent reply other threads:[~2013-04-03 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 14:27 [PATCH] git-tag(1): we tag HEAD by default Thomas Rast
2013-04-03 15:04 ` Junio C Hamano
2013-04-03 15:11 ` Thomas Rast
2013-04-03 15:17 ` Junio C Hamano [this message]
2013-04-03 18:20 ` Junio C Hamano
2013-04-03 15:18 ` Yann Droneaud
2013-04-03 15:22 ` Thomas Rast
2013-04-03 18:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvc8363v7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).