From: Junio C Hamano <gitster@pobox.com>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-send-email: don't return undefined value in extract_valid_address()
Date: Tue, 20 Nov 2012 14:14:05 -0800 [thread overview]
Message-ID: <7vvcczrkgi.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121120204736.GA7039@shrek.podlesie.net> (Krzysztof Mazur's message of "Tue, 20 Nov 2012 21:47:36 +0100")
Krzysztof Mazur <krzysiek@podlesie.net> writes:
> Yes, it's just to hide the warning, the error (warning in this case) it's
> already correctly generated:
>
> W: unable to extract a valid address from: x a.patch
But it is of no use if the message is sent out without the intended
recipient, no? It is too late when you notice it.
> Maybe we should change it to an error?
At least, when we are not giving the "final sanity check [Y/n]?"
prompt, I think the code should error out.
prev parent reply other threads:[~2012-11-20 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 12:20 [PATCH] git-send-email: don't return undefined value in extract_valid_address() Krzysztof Mazur
2012-11-20 20:27 ` Junio C Hamano
2012-11-20 20:47 ` Krzysztof Mazur
2012-11-20 22:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvcczrkgi.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=krzysiek@podlesie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox