From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: nathan.panike@gmail.com, git@vger.kernel.org
Subject: Re: [BUG] in rev-parse
Date: Thu, 15 Dec 2011 09:43:14 -0800 [thread overview]
Message-ID: <7vvcphohn1.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20111215070521.GB1327@sigill.intra.peff.net> (Jeff King's message of "Thu, 15 Dec 2011 02:05:21 -0500")
Jeff King <peff@peff.net> writes:
> Dropping the implied verify is easy (see below). But handling
> non-existant sha1s is a much more complicated change, as the regular
> abbreviation machinery assumes that they exist.
Hmm, I was very sure that I wrote a logic to do the "no such object" case
at least once, so I looked and found one in find_unique_abbrev(). But that
requires the caller to feed the full 160-bit sha1[] and perhaps it is not
easily used in the context of rev-parse (I didn't look further).
> Anyway, I'm not sure it's worth changing at this point. It's part of the
> plumbing API that has been that way forever,...
Ok.
next prev parent reply other threads:[~2011-12-15 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 18:49 [BUG] in rev-parse nathan.panike
2011-12-14 21:01 ` Jeff King
2011-12-15 3:20 ` Junio C Hamano
2011-12-15 7:05 ` Jeff King
2011-12-15 17:43 ` Junio C Hamano [this message]
2011-12-15 22:53 ` Michael Haggerty
2011-12-17 12:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvcphohn1.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nathan.panike@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).