From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: Bikeshedding advice on the ab/i18n-scripts series
Date: Mon, 16 May 2011 14:40:33 -0700 [thread overview]
Message-ID: <7vvcxajpda.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BANLkTi=FLWFzMFG5DgQiaN9kYW3pozJ6HQ@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 16 May 2011 23:32:55 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Mon, May 16, 2011 at 23:26, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Ævar Arnfjörð Bjarmason wrote:
>>
>>> That would require us to start extracting strings from all "say"
>>> functions. The reason we have only "gettext" and "eval_gettext" is so
>>> xgettext can extract them.
>>
>> Isn't that what the xgettext -k parameter is for?
>
> I'm not saying we can't use xgettext to extract these things. I'm
> saying I don't think it's a good idea.
>
> $ git --no-pager grep say git-submodule.sh
> git-submodule.sh: say "$(eval_gettext
> "Entering '\$prefix\$path'")"
Oh, I didn't mean to say "we _must_ call that _say_".
The discussion suggested to me that we may want two variants, one that
takes an incomplete single line and outputs a single complete line, and
the other that takes whatever the caller gives and outputs the translated
lines without further butchering the tail end. I missed that Jonathan
already mentioned gettext_nl and that is fine as well, but if we use a
function other than gettext I thought it would be better to use short and
sweet name for common cases.
prev parent reply other threads:[~2011-05-16 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 16:03 Bikeshedding advice on the ab/i18n-scripts series Ævar Arnfjörð Bjarmason
2011-05-16 16:26 ` Jonathan Nieder
2011-05-16 20:45 ` Junio C Hamano
2011-05-16 20:53 ` Ævar Arnfjörð Bjarmason
2011-05-16 20:58 ` Junio C Hamano
2011-05-16 21:13 ` Ævar Arnfjörð Bjarmason
2011-05-16 21:26 ` Jonathan Nieder
2011-05-16 21:32 ` Ævar Arnfjörð Bjarmason
2011-05-16 21:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvcxajpda.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).