From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ian Ward Comfort <icomfort@stanford.edu>, git@vger.kernel.org
Subject: Re: [PATCH v2] commit, status: #comment diff output in verbose mode
Date: Thu, 10 Mar 2011 16:45:14 -0800 [thread overview]
Message-ID: <7vvczq1o4l.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110310225233.GH15828@sigill.intra.peff.net> (Jeff King's message of "Thu, 10 Mar 2011 17:52:33 -0500")
Jeff King <peff@peff.net> writes:
> One reason to keep the existing behavior is that editors will tend to
> syntax-highlight the diff portion without much extra effort (in vim, at
> least, the syntax highlighting just includes the diff syntax
> highlighting for that section).
Hmm, thanks for pointing it out; it indeed is a valid concern.
Although I usually strongly resist changes in order to keep the user
experience stable, I didn't think about this one, as I don't let the
editor syntax highlight anything.
next prev parent reply other threads:[~2011-03-11 0:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 19:59 [PATCH v2] commit, status: #comment diff output in verbose mode Ian Ward Comfort
2011-03-10 22:52 ` Jeff King
2011-03-10 23:57 ` SZEDER Gábor
2011-03-11 0:45 ` Junio C Hamano [this message]
2011-03-11 1:23 ` Jeff King
2011-03-11 5:31 ` Jeff King
2011-03-11 8:49 ` Michael J Gruber
2011-03-17 7:37 ` Jeff King
2011-03-17 8:01 ` Michael J Gruber
2011-03-17 19:41 ` Jeff King
2011-03-13 18:34 ` Piotr Krukowiecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvczq1o4l.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=icomfort@stanford.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).