From: Junio C Hamano <gitster@pobox.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
Ping Yin <pkufranky@gmail.com>, Jeff King <peff@peff.net>,
Johan Herland <johan@herland.net>,
A Large Angry SCM <gitzilla@gmail.com>, git <git@vger.kernel.org>
Subject: Re: What should "git submodule summary" give before an initial commit?
Date: Wed, 03 Mar 2010 22:43:57 -0800 [thread overview]
Message-ID: <7vvddcd1si.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <fabb9a1e1003032236x59a781b8ne0266877db25d001@mail.gmail.com> (Sverre Rabbelier's message of "Thu\, 4 Mar 2010 07\:36\:20 +0100")
Sverre Rabbelier <srabbelier@gmail.com> writes:
> Yes, that's what I came up with after sending my email, commands that
> _default_ to HEAD as revision should instead default to an empty
> commit when there is no HEAD yet. Perhaps something we can add to
> parse_opt and then make sure that all commands we care about use that
> feature?
I doubt it would be very much useful as a general feature, as sometimes we
default to HEAD because we want a tree-ish (in which case using "empty
tree" would be appropriate) and other times because we want an actual
commit (e.g. "git commit --amend" should exit, not "amend an empty tree")
and we would need to be careful to study each codepath and use the
appropriate one.
But you are welcome to try and prove me wrong with a working patch ;-).
next prev parent reply other threads:[~2010-03-04 6:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 12:21 Latest master failing t7401 submodule tests A Large Angry SCM
2010-03-03 19:45 ` Junio C Hamano
2010-03-03 20:02 ` Jeff King
2010-03-03 20:32 ` Junio C Hamano
2010-03-03 20:42 ` Jeff King
2010-03-03 21:04 ` Junio C Hamano
2010-03-03 21:28 ` Junio C Hamano
2010-03-03 21:58 ` What should "git submodule summary" give before an initial commit? Junio C Hamano
2010-03-03 23:10 ` Johan Herland
2010-03-04 0:36 ` Jens Lehmann
2010-03-04 6:01 ` Sverre Rabbelier
2010-03-04 6:22 ` Junio C Hamano
2010-03-04 6:36 ` Sverre Rabbelier
2010-03-04 6:43 ` Junio C Hamano [this message]
2010-03-04 6:48 ` Sverre Rabbelier
2010-03-03 22:57 ` Latest master failing t7401 submodule tests Jeff King
2010-03-03 20:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvddcd1si.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitzilla@gmail.com \
--cc=johan@herland.net \
--cc=peff@peff.net \
--cc=pkufranky@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).