From: Junio C Hamano <gitster@pobox.com>
To: Michele Ballabio <barra_cuda@katamail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] shortlog: do not stall when there is no input
Date: Wed, 24 Feb 2010 11:31:39 -0800 [thread overview]
Message-ID: <7vvddmmnvo.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <201002242020.27801.barra_cuda@katamail.com> (Michele Ballabio's message of "Wed\, 24 Feb 2010 20\:20\:27 +0100")
Michele Ballabio <barra_cuda@katamail.com> writes:
> A simple "git shortlog" outside of a git repository used to stall
> waiting for an input. Fix this by testing with isatty() before
> calling read_from_stdin().
I'd actually prefer doing what "git commit" does. Give a helpful hint
that it is waiting for input from the standard input, but do read from
standard input as the program is instructed to do.
That way people who drive the program with expect will not be broken ;-)
but that is a minor point.
next prev parent reply other threads:[~2010-02-24 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 19:20 [PATCH] shortlog: do not stall when there is no input Michele Ballabio
2010-02-24 19:31 ` Junio C Hamano [this message]
2010-02-24 20:49 ` [PATCH] shortlog: warn the user " Michele Ballabio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvddmmnvo.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barra_cuda@katamail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).